[Openmp-commits] [PATCH] D11821: [OpenMP] Initial testsuite change to purely llvm-lit based testing

[Jonathan Peyton via Openmp-commits]

jlpeyton updated this revision to Diff 33716.
jlpeyton added a comment.

> Why do we need windows.h here? clock() is in time.h.

>  I don't understand why we're sleeping this way -- it is not really sleeping, but rather busy-waiting on the clock. Shouldn't we use something like nanosleep() instead?


I've changed the my_sleep() function to actually sleep instead of busy wait.  Windows uses Sleep() (which requires windows.h now) and Unices will use nanosleep().

> my_sleep is not called in this file.


Removed.

> my_sleep is not called in this file.


Removed.

> Please remove commented-out code.

>  Here too (or maybe this shouldn't be commented?)


Changed to critical section

> my_sleep is not called in this file.


Removed.


Repository:
  rL LLVM

http://reviews.llvm.org/D11821

Files:
  runtime/CMakeLists.txt
  runtime/src/CMakeLists.txt
  runtime/test/CMakeLists.txt
  runtime/test/api/has_openmp.c
  runtime/test/api/omp_get_num_threads.c
  runtime/test/api/omp_get_wtick.c
  runtime/test/api/omp_get_wtime.c
  runtime/test/api/omp_in_parallel.c
  runtime/test/atomic/omp_atomic.c
  runtime/test/barrier/omp_barrier.c
  runtime/test/critical/omp_critical.c
  runtime/test/flush/omp_flush.c
  runtime/test/lit.cfg
  runtime/test/lit.site.cfg.in
  runtime/test/lock/omp_lock.c
  runtime/test/lock/omp_nest_lock.c
  runtime/test/lock/omp_test_lock.c
  runtime/test/lock/omp_test_nest_lock.c
  runtime/test/master/omp_master.c
  runtime/test/master/omp_master_3.c
  runtime/test/omp_my_sleep.h
  runtime/test/omp_testsuite.h
  runtime/test/parallel/omp_nested.c
  runtime/test/parallel/omp_parallel_copyin.c
  runtime/test/parallel/omp_parallel_default.c
  runtime/test/parallel/omp_parallel_firstprivate.c
  runtime/test/parallel/omp_parallel_if.c
  runtime/test/parallel/omp_parallel_num_threads.c
  runtime/test/parallel/omp_parallel_private.c
  runtime/test/parallel/omp_parallel_reduction.c
  runtime/test/parallel/omp_parallel_shared.c
  runtime/test/tasking/omp_task.c
  runtime/test/tasking/omp_task_final.c
  runtime/test/tasking/omp_task_firstprivate.c
  runtime/test/tasking/omp_task_if.c
  runtime/test/tasking/omp_task_imp_firstprivate.c
  runtime/test/tasking/omp_task_private.c
  runtime/test/tasking/omp_task_shared.c
  runtime/test/tasking/omp_task_untied.c
  runtime/test/tasking/omp_taskwait.c
  runtime/test/tasking/omp_taskyield.c
  runtime/test/threadprivate/omp_threadprivate.c
  runtime/test/threadprivate/omp_threadprivate_for.c
  runtime/test/worksharing/for/omp_for_collapse.c
  runtime/test/worksharing/for/omp_for_firstprivate.c
  runtime/test/worksharing/for/omp_for_lastprivate.c
  runtime/test/worksharing/for/omp_for_nowait.c
  runtime/test/worksharing/for/omp_for_ordered.c
  runtime/test/worksharing/for/omp_for_private.c
  runtime/test/worksharing/for/omp_for_reduction.c
  runtime/test/worksharing/for/omp_for_schedule_auto.c
  runtime/test/worksharing/for/omp_for_schedule_dynamic.c
  runtime/test/worksharing/for/omp_for_schedule_guided.c
  runtime/test/worksharing/for/omp_for_schedule_static.c
  runtime/test/worksharing/for/omp_for_schedule_static_3.c
  runtime/test/worksharing/for/omp_parallel_for_firstprivate.c
  runtime/test/worksharing/for/omp_parallel_for_if.c
  runtime/test/worksharing/for/omp_parallel_for_lastprivate.c
  runtime/test/worksharing/for/omp_parallel_for_ordered.c
  runtime/test/worksharing/for/omp_parallel_for_private.c
  runtime/test/worksharing/for/omp_parallel_for_reduction.c
  runtime/test/worksharing/sections/omp_parallel_sections_firstprivate.c
  runtime/test/worksharing/sections/omp_parallel_sections_lastprivate.c
  runtime/test/worksharing/sections/omp_parallel_sections_private.c
  runtime/test/worksharing/sections/omp_parallel_sections_reduction.c
  runtime/test/worksharing/sections/omp_section_firstprivate.c
  runtime/test/worksharing/sections/omp_section_lastprivate.c
  runtime/test/worksharing/sections/omp_section_private.c
  runtime/test/worksharing/sections/omp_sections_nowait.c
  runtime/test/worksharing/sections/omp_sections_reduction.c
  runtime/test/worksharing/single/omp_single.c
  runtime/test/worksharing/single/omp_single_copyprivate.c
  runtime/test/worksharing/single/omp_single_nowait.c
  runtime/test/worksharing/single/omp_single_private.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D11821.33716.patch
Type: text/x-patch
Size: 146043 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20150901/d5c2dc0a/attachment-0001.bin>