[Openmp-commits] [PATCH] D14565: Missing include kmp_config.h

[John Mellor-Crummey via Openmp-commits]

jmellorcrummey added a subscriber: jmellorcrummey.
jmellorcrummey added a comment.

My aim is to keep ompt-general.c completely of details specific to a particular runtime, so its code can be reused in other runtimes. For that reason, I don't support adding an include of kmp_config.h to ompt-general.c.

I understand the problem that you are trying to address: that ompt-event-specific.h included through ompt-internal.h in ompt-general.c does not inherit see definitions for OMPT_TRACE nor OMPT_BLAME.

The right way to fix this is to drop the include of ompt-internal.h in ompt-general.c. It gets there anyway through ompt-specific.c.

ompt-specific.c includes kmp.h (which includes kmp_config.h) before including ompt-internal.h.

Please update your diff to drop the include of both ompt-internal.h and kmp_config.h in ompt-general.c.

Also, when you prepare diffs, make sure to use "git diff -U999999" so the full context of the diff is available. That's the way that they want patches prepared using differential.


http://reviews.llvm.org/D14565