[Openmp-commits] [openmp] r231779 - issuing of incorrect warning fixed

[Hal Finkel]

----- Original Message -----
> From: "Andrey Churbanov" <Andrey.Churbanov at intel.com>
> To: openmp-commits at cs.uiuc.edu
> Sent: Tuesday, March 10, 2015 4:34:38 AM
> Subject: [Openmp-commits] [openmp] r231779 - issuing of incorrect warning	fixed
> 
> Author: achurbanov
> Date: Tue Mar 10 04:34:38 2015
> New Revision: 231779
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=231779&view=rev
> Log:
> issuing of incorrect warning fixed

In the future, please make these commit messages more detailed. What warning? Why was it broken previously? [I believe these were explained when the patch was posted for review -- and should appear again in the commit log].

Thanks again,
Hal

> 
> Modified:
>     openmp/trunk/runtime/src/kmp_affinity.cpp
> 
> Modified: openmp/trunk/runtime/src/kmp_affinity.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/openmp/trunk/runtime/src/kmp_affinity.cpp?rev=231779&r1=231778&r2=231779&view=diff
> ==============================================================================
> --- openmp/trunk/runtime/src/kmp_affinity.cpp (original)
> +++ openmp/trunk/runtime/src/kmp_affinity.cpp Tue Mar 10 04:34:38
> 2015
> @@ -3247,8 +3247,8 @@ __kmp_affinity_process_placelist(kmp_aff
>                      }
>                      else if ((j > maxOsId) ||
>                        (! KMP_CPU_ISSET(j, KMP_CPU_INDEX(osId2Mask,
>                        j)))) {
> -                        if (__kmp_affinity_verbose ||
> (__kmp_affinity_warnings
> -                          && (__kmp_affinity_type !=
> affinity_none))) {
> +                        if ((__kmp_affinity_verbose ||
> (__kmp_affinity_warnings
> +                          && (__kmp_affinity_type !=
> affinity_none))) && i < count - 1) {
>                              KMP_WARNING(AffIgnoreInvalidProcID, j);
>                          }
>                          KMP_CPU_CLR(j, tempMask);
> @@ -3279,8 +3279,8 @@ __kmp_affinity_process_placelist(kmp_aff
>                      }
>                      else if ((j > maxOsId) ||
>                        (! KMP_CPU_ISSET(j, KMP_CPU_INDEX(osId2Mask,
>                        j)))) {
> -                        if (__kmp_affinity_verbose ||
> (__kmp_affinity_warnings
> -                          && (__kmp_affinity_type !=
> affinity_none))) {
> +                        if ((__kmp_affinity_verbose ||
> (__kmp_affinity_warnings
> +                          && (__kmp_affinity_type !=
> affinity_none))) && i < count - 1) {
>                              KMP_WARNING(AffIgnoreInvalidProcID, j);
>                          }
>                          KMP_CPU_CLR(j, tempMask);
> 
> 
> _______________________________________________
> Openmp-commits mailing list
> Openmp-commits at dcs-maillist2.engr.illinois.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/openmp-commits
> 

-- 
Hal Finkel
Assistant Computational Scientist
Leadership Computing Facility
Argonne National Laboratory