[Openmp-commits] [PATCH] D11493: LibompMicroTests.cmake: Invoke 'test' instead of using '[ x -eq y ]'

Hans Wennborg hans at chromium.org
Fri Jul 24 13:27:06 PDT 2015

hans created this revision.
hans added a reviewer: jlpeyton.
hans added a subscriber: openmp-commits.

I was getting this cmake error on Mac OS X:

  CMake Error: Error in cmake code at
  Parse error.  Function missing ending ")".  Instead found bad character with text "[".

Perhaps invoking 'test' is less confusing for cmake.



Index: runtime/cmake/LibompMicroTests.cmake
--- runtime/cmake/LibompMicroTests.cmake
+++ runtime/cmake/LibompMicroTests.cmake
@@ -137,7 +137,7 @@
   OUTPUT  test-relo/.success test-relo/readelf.log
   COMMAND ${CMAKE_COMMAND} -E make_directory ${CMAKE_CURRENT_BINARY_DIR}/test-relo
   COMMAND readelf -d ${LIBOMP_OUTPUT_DIRECTORY}/${LIBOMP_LIB_FILE} > test-relo/readelf.log
-  COMMAND grep -e TEXTREL test-relo/readelf.log \; [ $$? -eq 1 ]
+  COMMAND grep -e TEXTREL test-relo/readelf.log \; test $$? -eq 1
   COMMAND ${CMAKE_COMMAND} -E touch test-relo/.success
   DEPENDS omp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D11493.30599.patch
Type: text/x-patch
Size: 649 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20150724/9d9efb59/attachment.bin>

More information about the Openmp-commits mailing list