[Openmp-commits] [PATCH] D11269: Patch out an (apparently unwarranted) fatal assertion in OpenMP runtime until preconditions are met

[Jonathan Peyton]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL243032: Patch out a fatal assertion in OpenMP runtime until preconditions are met (authored by jlpeyton).

Changed prior to commit:
  http://reviews.llvm.org/D11269?vs=29915&id=30512#toc

Repository:
  rL LLVM

http://reviews.llvm.org/D11269

Files:
  openmp/trunk/runtime/src/kmp_runtime.c

Index: openmp/trunk/runtime/src/kmp_runtime.c
===================================================================
--- openmp/trunk/runtime/src/kmp_runtime.c
+++ openmp/trunk/runtime/src/kmp_runtime.c
@@ -2089,7 +2089,11 @@
 
     if ( __kmp_tasking_mode != tskm_immediate_exec ) {
         // Set master's task team to team's task team. Unless this is hot team, it should be NULL.
+#if 0
+        // Patch out an assertion that trips while the runtime seems to operate correctly.
+        // Avoiding the preconditions that cause the assertion to trip has been promised as a forthcoming patch.
         KMP_DEBUG_ASSERT(master_th->th.th_task_team == parent_team->t.t_task_team[master_th->th.th_task_state]);
+#endif
         KA_TRACE( 20, ( "__kmp_fork_call: Master T#%d pushing task_team %p / team %p, new task_team %p / team %p\n",
                       __kmp_gtid_from_thread( master_th ), master_th->th.th_task_team,
                       parent_team, team->t.t_task_team[master_th->th.th_task_state], team ) );


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D11269.30512.patch
Type: text/x-patch
Size: 1018 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20150723/f8a66635/attachment.bin>