[Openmp-commits] [PATCH] D11253: [cmake] Support enabling -Werror in the OpenMP runtime CMake build and clean up the build.

[Chandler Carruth]

chandlerc added a comment.

Good catch. Anything else? Not at a computer to update the patch but I will be later.


================
Comment at: runtime/CMakeLists.txt:44
@@ -43,1 +43,3 @@
     "enable assertions?")
+  set(LIBOMP_ENABLE_WERROR TRUE CACHE BOOL
+    "Enable -Werror flags to turn warnings into errors for supporting compilers.")
----------------
jlpeyton wrote:
> I think this should be FALSE.  Even LLVM has it off by default.  For example, on Linux building x86_64, gcc 4.8 warns that it might not be able to inline something that has an "always inline" attribute.
Of course, sorry. Will fix.


http://reviews.llvm.org/D11253