[Openmp-commits] [PATCH] D11259: Fix OMPT support for task frames for parallel regions and parallel regions + loops

[Jonas Hahnfeld]

Hahnfeld added a subscriber: Hahnfeld.
Hahnfeld added a comment.

Besides the #if 0 around the assert only some minor issues about indention. I don't know how rigid we should be with this...


================
Comment at: runtime/src/kmp_gsupport.c:493
@@ -491,1 +492,3 @@
+	// Record that we re-entered the runtime system in the implicit
+	// task frame representing the parallel region. 
         ompt_frame = __ompt_get_task_frame_internal(0);
----------------
Indention

================
Comment at: runtime/src/kmp_gsupport.c:522
@@ -507,1 +521,3 @@
+        }
+
     }
----------------
Looks like 3 space indention while there is 4 space indention around...

================
Comment at: runtime/src/kmp_gsupport.c:546
@@ -515,1 +545,3 @@
+        }
+#endif
     }
----------------
Indention

================
Comment at: runtime/src/kmp_gsupport.c:554
@@ +553,3 @@
+	    // Record that we re-entered the runtime system in the frame that 
+	    // created the parallel region.
+            ompt_frame->reenter_runtime_frame = __builtin_frame_address(0);
----------------
Indention

================
Comment at: runtime/src/kmp_runtime.c:2094
@@ -2089,2 +2093,3 @@
         KMP_DEBUG_ASSERT(master_th->th.th_task_team == parent_team->t.t_task_team[master_th->th.th_task_state]);
+#endif
         KA_TRACE( 20, ( "__kmp_fork_call: Master T#%d pushing task_team %p / team %p, new task_team %p / team %p\n",
----------------
This probably shouldn't be here, it's part of another issue...


http://reviews.llvm.org/D11259