[Openmp-commits] [PATCH] LLVM OpenMP CMake Overhaul

Peyton, Jonathan L jonathan.l.peyton at intel.com
Tue Jul 7 09:24:28 PDT 2015

I apologize.  You’re absolutely right.

My ETA for when I plan to commit this patch to trunk is when it gets approved.

-- Johnny

From: Chandler Carruth [mailto:chandlerc at google.com]
Sent: Tuesday, July 7, 2015 11:00 AM
To: Peyton, Jonathan L; Jack Howarth; reviews+D10656+public+dda1fdcafb4c32bf at reviews.llvm.org
Cc: C Bergström; openmp-commits at dcs-maillist2.engr.illinois.edu; howarth.mailing.lists at apple.com; llvm-commits at cs.uiuc.edu
Subject: Re: [Openmp-commits] [PATCH] LLVM OpenMP CMake Overhaul

Jonathan, that is not the code review policy of the LLVM community. Please, do not try to force code review by setting a time table. Once you ask for code review, it is your responsibility to wait for your reviewers to approve the patch.

I'm sorry that last week didn't get you a code review. Lots of folks were on vacation, and in the US it was a short week due to holidays. Unfortunately, this is the reality, and doesn't mean you should rush the patch.

On Tue, Jul 7, 2015 at 8:53 AM Peyton, Jonathan L <jonathan.l.peyton at intel.com<mailto:jonathan.l.peyton at intel.com>> wrote:
I feel there has been ample opportunity to review the new iterations of this patch.  And if no one objects, I'm going to commit this tomorrow.  Post commit reviews are always welcome.

-- Johnny

-----Original Message-----
From: Jack Howarth [mailto:howarth.mailing.lists at gmail.com<mailto:howarth.mailing.lists at gmail.com>]
Sent: Tuesday, July 7, 2015 7:25 AM
To: reviews+D10656+public+dda1fdcafb4c32bf at reviews.llvm.org<mailto:reviews%2BD10656%2Bpublic%2Bdda1fdcafb4c32bf at reviews.llvm.org>
Cc: Peyton, Jonathan L; Chandler Carruth; C Bergström; openmp-commits at dcs-maillist2.engr.illinois.edu<mailto:openmp-commits at dcs-maillist2.engr.illinois.edu>; Cownie, James H; howarth.mailing.lists at apple.com<mailto:howarth.mailing.lists at apple.com>; llvm-commits at cs.uiuc.edu<mailto:llvm-commits at cs.uiuc.edu>
Subject: Re: [PATCH] LLVM OpenMP CMake Overhaul

      We are now a week away from the branching of 3.7.0. Do you have an ETA for when you plan to commit this patch to trunk?

On Tue, Jun 30, 2015 at 5:08 PM, Jonathan Peyton <jonathan.l.peyton at intel.com<mailto:jonathan.l.peyton at intel.com>> wrote:
> Addressing most of Chandler's remaining issues with this third iteration.
> - There is no longer a LibompSourceFiles.cmake file.  The files are
> grabbed inside src/CMakeLists.txt
> - The -m32 flag is guarded by if(CMAKE_SIZEOF_VOID_P EQUAL 8) so we only use it when using a x86_64 toolchain to compile i386.
> - Removed passing in of _KMP_BUILD_TIME.
> - I've gotten the library to build using Unix Makefiles, NMake Makefiles, and NInja on Windows in standalone mode.  There is still one issue when trying to build in a Windows LLVM tree which is that LLVM adds numerous -wXYZ flags by using add_llvm_definitions() which causes the resource compiler (RC.exe) to include them in its command which causes an unknown flag error.
>   rL LLVM
> http://reviews.llvm.org/D10656
> Files:
>   runtime/CMakeLists.txt
>   runtime/cmake/BuildPLRules.cmake
>   runtime/cmake/Clang/AsmFlags.cmake
>   runtime/cmake/Clang/CFlags.cmake
>   runtime/cmake/CommonFlags.cmake
>   runtime/cmake/Definitions.cmake
>   runtime/cmake/GNU/AsmFlags.cmake
>   runtime/cmake/GNU/CFlags.cmake
>   runtime/cmake/GNU/FortranFlags.cmake
>   runtime/cmake/GetArchitecture.cmake
>   runtime/cmake/HelperFunctions.cmake
>   runtime/cmake/Intel/AsmFlags.cmake
>   runtime/cmake/Intel/CFlags.cmake
>   runtime/cmake/Intel/FortranFlags.cmake
>   runtime/cmake/LibompCheckFortranFlag.cmake
>   runtime/cmake/LibompCheckLinkerFlag.cmake
>   runtime/cmake/LibompDefinitions.cmake
>   runtime/cmake/LibompExports.cmake
>   runtime/cmake/LibompGetArchitecture.cmake
>   runtime/cmake/LibompHandleFlags.cmake
>   runtime/cmake/LibompMicroTests.cmake
>   runtime/cmake/LibompUtils.cmake
>   runtime/cmake/MSVC/AsmFlags.cmake
>   runtime/cmake/MSVC/CFlags.cmake
>   runtime/cmake/MicroTests.cmake
>   runtime/cmake/PerlFlags.cmake
>   runtime/cmake/SourceFiles.cmake
>   runtime/cmake/config-ix.cmake
>   runtime/src/CMakeLists.txt
>   http://reviews.llvm.org/settings/panel/emailpreferences/
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu<mailto:llvm-commits at cs.uiuc.edu>
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

Openmp-commits mailing list
Openmp-commits at dcs-maillist2.engr.illinois.edu<mailto:Openmp-commits at dcs-maillist2.engr.illinois.edu>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20150707/ffee23df/attachment.html>

More information about the Openmp-commits mailing list