[Openmp-commits] [PATCH] LLVM OpenMP CMake Overhaul

[Peyton, Jonathan L]

I feel there has been ample opportunity to review the new iterations of this patch.  And if no one objects, I'm going to commit this tomorrow.  Post commit reviews are always welcome.

-- Johnny

-----Original Message-----
From: Jack Howarth [mailto:howarth.mailing.lists at gmail.com] 
Sent: Tuesday, July 7, 2015 7:25 AM
To: reviews+D10656+public+dda1fdcafb4c32bf at reviews.llvm.org
Cc: Peyton, Jonathan L; Chandler Carruth; C Bergström; openmp-commits at dcs-maillist2.engr.illinois.edu; Cownie, James H; howarth.mailing.lists at apple.com; llvm-commits at cs.uiuc.edu
Subject: Re: [PATCH] LLVM OpenMP CMake Overhaul

Jonathan,
      We are now a week away from the branching of 3.7.0. Do you have an ETA for when you plan to commit this patch to trunk?
               Jack

On Tue, Jun 30, 2015 at 5:08 PM, Jonathan Peyton <jonathan.l.peyton at intel.com> wrote:
> Addressing most of Chandler's remaining issues with this third iteration.
>
> - There is no longer a LibompSourceFiles.cmake file.  The files are 
> grabbed inside src/CMakeLists.txt
> - The -m32 flag is guarded by if(CMAKE_SIZEOF_VOID_P EQUAL 8) so we only use it when using a x86_64 toolchain to compile i386.
> - Removed passing in of _KMP_BUILD_TIME.
> - I've gotten the library to build using Unix Makefiles, NMake Makefiles, and NInja on Windows in standalone mode.  There is still one issue when trying to build in a Windows LLVM tree which is that LLVM adds numerous -wXYZ flags by using add_llvm_definitions() which causes the resource compiler (RC.exe) to include them in its command which causes an unknown flag error.
>
>
> REPOSITORY
>   rL LLVM
>
> http://reviews.llvm.org/D10656
>
> Files:
>   runtime/CMakeLists.txt
>   runtime/cmake/BuildPLRules.cmake
>   runtime/cmake/Clang/AsmFlags.cmake
>   runtime/cmake/Clang/CFlags.cmake
>   runtime/cmake/CommonFlags.cmake
>   runtime/cmake/Definitions.cmake
>   runtime/cmake/GNU/AsmFlags.cmake
>   runtime/cmake/GNU/CFlags.cmake
>   runtime/cmake/GNU/FortranFlags.cmake
>   runtime/cmake/GetArchitecture.cmake
>   runtime/cmake/HelperFunctions.cmake
>   runtime/cmake/Intel/AsmFlags.cmake
>   runtime/cmake/Intel/CFlags.cmake
>   runtime/cmake/Intel/FortranFlags.cmake
>   runtime/cmake/LibompCheckFortranFlag.cmake
>   runtime/cmake/LibompCheckLinkerFlag.cmake
>   runtime/cmake/LibompDefinitions.cmake
>   runtime/cmake/LibompExports.cmake
>   runtime/cmake/LibompGetArchitecture.cmake
>   runtime/cmake/LibompHandleFlags.cmake
>   runtime/cmake/LibompMicroTests.cmake
>   runtime/cmake/LibompUtils.cmake
>   runtime/cmake/MSVC/AsmFlags.cmake
>   runtime/cmake/MSVC/CFlags.cmake
>   runtime/cmake/MicroTests.cmake
>   runtime/cmake/PerlFlags.cmake
>   runtime/cmake/SourceFiles.cmake
>   runtime/cmake/config-ix.cmake
>   runtime/src/CMakeLists.txt
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>