[Openmp-commits] [PATCH] D12403: Fix GCC warning 'always_inline function might not be inlinable'

[Jonas Hahnfeld via Openmp-commits]

Hahnfeld added a comment.

In http://reviews.llvm.org/D12403#236292, @AndreyChurbanov wrote:

> Jonas,
>
> > although I don't really understand why there shouldn't be inlining with __STRICT_ANSI__ being defined...
>
>
> The GCC documentation for -ansi option says that "For the C compiler, it disables recognition of C++ style ‘//’ comments as well as the `inline `keyword."
>
> So the way it is written now there may be problems with C compilation with -ansi option. The ittnotify team told me they had complaints from at least two customers about the `inline` keyword while -ansi used, so it is better to avoid using it.
>
> Thanks,
> Andrey


Thanks for this explanation. Then your diff is without doubt preferable and LGTM.

Greetings,
Jonas


Repository:
  rL LLVM

http://reviews.llvm.org/D12403