[Openmp-commits] [PATCH] D11821: [OpenMP] Initial testsuite change to purely llvm-lit based testing

hfinkel@anl.gov via Openmp-commits openmp-commits at lists.llvm.org
Sat Aug 29 12:16:36 PDT 2015


hfinkel added inline comments.

================
Comment at: runtime/test/atomic/omp_atomic.c:5
@@ +4,3 @@
+#include "omp_testsuite.h"
+#include "omp_my_sleep.h"
+
----------------
my_sleep is not called in this file.

================
Comment at: runtime/test/critical/omp_critical.c:4
@@ +3,3 @@
+#include "omp_testsuite.h"
+#include "omp_my_sleep.h"
+
----------------
my_sleep is not called in this file.

================
Comment at: runtime/test/tasking/omp_task_if.c:22
@@ +21,3 @@
+        my_sleep (SLEEPTIME);
+        //#pragma omp flush (count)
+        result = (0 == count);
----------------
Please remove commented-out code.

================
Comment at: runtime/test/tasking/omp_task_if.c:26
@@ +25,3 @@
+      count = 1;
+      //#pragma omp flush (count)
+    } /* end of single */
----------------
Here too (or maybe this shouldn't be commented?)

================
Comment at: runtime/test/worksharing/for/omp_for_schedule_dynamic.c:15
@@ +14,3 @@
+#include "omp_testsuite.h"
+#include "omp_my_sleep.h"
+
----------------
my_sleep is not called in this file.


Repository:
  rL LLVM

http://reviews.llvm.org/D11821





More information about the Openmp-commits mailing list