[Openmp-commits] [PATCH] D11821: [OpenMP] Initial testsuite change to purely llvm-lit based testing

[hfinkel@anl.gov via Openmp-commits]

hfinkel added a comment.

In http://reviews.llvm.org/D11821#224562, @jlpeyton wrote:

> > I see code in the lit/cmake files to handle windows, does this currently work? The tests seem to include unistd.h.
>
>
> Currently, it is Unices and Mac only.  I only put the Windows logic in there in anticipation that it will be supported at some point.  Right now, users can't easily use libomp.so on Windows because the clang front end doesn't include it when using -fopenmp (libomp.lib has to be explicitly linked).


Okay (although there is a patch out to fix the libomp.lib problem, the larger problem is that the tests themselves won't work because of the unistd.h dependency). Although we normally frown on committing dead code, in this particular case, the couple of lines seems straightforward, so I don't have a strong opinion. We should probably have it explicitly fail on Windows, however, with some informative 'Regression tests not supported yet' message instead of having the user run all of the tests and having them all appear to fail. We can remove this once we actually update the tests to compile on Windows.

(I've also added Chandler to the review; he told me he'd look at this soon).


Repository:
  rL LLVM

http://reviews.llvm.org/D11821