[Openmp-commits] [PATCH] Validation using OpenMP validation suite - adding support for cmake Part 2 of 2

Jonathan Peyton jonathan.l.peyton at intel.com
Tue Apr 21 10:15:19 PDT 2015


There seems to be a number of issues here.  I'm trying these patches (http://reviews.llvm.org/D7637, http://reviews.llvm.org/D7638, http://reviews.llvm.org/D8752, and http://reviews.llvm.org/D8751) and here is what I have come up with:

1. This entire system doesn't seem to work if libiomp5 is a standalone product outside of an llvm project directory.
2. Including the testsuite/Makefile in the top level Makefile seems wrong.  It seems as though recursive Make should be called here.  For instance if I try to run "make clean", it now gives me an error (bin/ directory doesn't exist in the runtime/ directory) which is unacceptable.
3. I had to call Make inside the testsuite/ directory to have an LLVM-IR/ directory created inside the testsuite/ directory which isn't user friendly.

Can someone explain the overall process of how this system is supposed to be called by the user and then document it in the testsuite/README?.  The Phabricator review shows most of it being deleted.


REPOSITORY
  rL LLVM

http://reviews.llvm.org/D8752

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the Openmp-commits mailing list