[Openmp-commits] [PATCH] Add new files for OMPT

Olga Malysheva olga.malysheva at intel.com
Fri Apr 10 09:02:57 PDT 2015


================
Comment at: runtime/src/ompt-internal.h:7
@@ +6,3 @@
+
+#define OMPT_VERSION 1
+
----------------
I suggest using "1.0".

================
Comment at: runtime/src/ompt-specific.c:32
@@ +31,3 @@
+#else
+#define NEXT_ID(id_ptr,tid) (__sync_fetch_and_add(id_ptr, 1))
+#endif
----------------
Can you consider using  KMP_TEST_THEN_INC* macro instead (src/kmp_os.h) to make it working on Windows?

http://reviews.llvm.org/D8917

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the Openmp-commits mailing list