charithaintc wrote: > LGTM % comments I would also check if the subview offsets satisfy the base pitch alignment requirement (at least emit warning for static cases). otherwise it can silently mis-compile https://github.com/llvm/llvm-project/pull/225556