[Mlir-commits] [mlir] [mlir][ArmNeon] Add pack/mmt4d path to f32 linalg.matmul integration test (PR #225063)

[Andrzej Warzyński]

banach-space wrote:

> The new path is `linalg.pack` -> `linalg.mmt4d` -> `linalg.unpack`. The dyn case only exercises masked vectorization of the plain matmul. Do we want to keep it alive?

OK, I forgot that the number of variants is starting to grow. I propose the following:
* `pack-unpack-mmt4d-f32.mlir` should implement _only one_ matmul type (static) and lower that through different means (_without_ packing vs _with_ packing). The focus should be on the MMT4D path. Plain `linalg.matmul` is lowered via `-test-lower-to-llvm`. Element type - `f32`.
* `pack-unpack-mmt4d-i8.mlir` should implement _only one_ matmul type (static) and lower that through different means (_without_ packing vs _with_ packing). The focus should be on the MMT4D path. Plain `linalg.matmul` is lowered via `-test-lower-to-llvm` Element type - `i8`.
* `matmul-f32.mlir` - dynamic matmul, only f32. Lowered via tiling + vectorization.
* `matmul.mlir` -  should be split into e.g. `matmul-f32.mlir` and `matmul-i8.mlir`.

Importantly, could you add a note in `pack-unpack-mmt4d-f32.mlir` that `linalg.matmul` is lowered via `-test-lower-to-llvm` and only added to provide reference check?

https://github.com/llvm/llvm-project/pull/225063