[Mlir-commits] [mlir] [mlir][ArithToSPIRV] Fix crash on tensor arith.uitofp/sitofp lowering (PR #227102)

[Igor Wodiany]

https://github.com/IgWod commented:

> Actually srcType is the operand type after type conversion, so tensor<2xi32> becomes !spirv.array<2 x i32>, whose element type isn't int/float.

Technically the element type is int in here, it's just `getElementTypeOrSelf` that cannot extract it. I believe it's due to the fact that `spirv.array` is not a `ShapedType`.

In general this LGTM and tests are sufficient -- than you for the explanation. Once the remaining comments are addressed I'm happy to approve it and merge it.

https://github.com/llvm/llvm-project/pull/227102