[Mlir-commits] [mlir] [mlir] Apply the default --split-input-file marker after parsing (PR #226361)

[Mehdi Amini]

joker-eph wrote:

> On the RFC being recent: the problems with cl::opt (global state, static initializers, per-option overhead, options leaking into tools that don't want them) have been discussed for years, and there is broad agreement on moving away from it. Many tools have migrated to OptTable over the years.

Sorry, but I don't follow your argument here: yes, the problems have been discussed for years, that doesn't mean your RFC is going to go through though, there have been many RFCs in the last 10 years... 

> The reason to remove cl::callback (and other questionable cl:: features) now rather than last is to stop new uses from appearing while the migration is in flight.

Sure, that's a reason, but that seem very weak of an argument to me: how many new used of cl::callback are gonna appear while you're migrating a library? 
Especially, when you migrate a library, it cannot slide back into adding a use of cl::callback, since by definition it'll have migrated. So if you take libraries one by one, then every time you migrate one you remove any possibility of introducing a use of cl::callback for this library.

https://github.com/llvm/llvm-project/pull/226361