[Mlir-commits] [mlir] [MLIR][SymbolTable] Fix crash in SymbolUserMap on unregistered-dialect (PR #226630)

[Mehdi Amini]

================
@@ -1055,7 +1055,12 @@ SymbolUserMap::SymbolUserMap(SymbolTableCollection &symbolTable,
   auto walkFn = [&](Operation *symbolTableOp, bool allUsesVisible) {
     for (Operation &nestedOp : symbolTableOp->getRegion(0).getOps()) {
       auto symbolUses = SymbolTable::getSymbolUses(&nestedOp);
-      assert(symbolUses && "expected uses to be valid");
+      if (!symbolUses) {
+        for (Operation &maybeSymbol : symbolTableOp->getRegion(0).getOps())
+          if (getNameIfSymbol(&maybeSymbol))
+            symbolToUsers[&maybeSymbol].insert(&nestedOp);
+        continue;
+      }
----------------
joker-eph wrote:

We need a test please.

Also can you document this? I don't quite follow what this code is doing.

https://github.com/llvm/llvm-project/pull/226630