[Mlir-commits] [mlir] [mlir][linalg] Fix rank-reducing insert_slice vectorization writing to wrong dims (PR #226490)

[Federico Bruzzone]

================
@@ -441,6 +441,44 @@ static SmallVector<bool> computeInBoundsFromPermutationMap(
   return inBounds;
 }
 
+/// Computes the mask type and sizes for a transfer of `vecType` at `indices`.
+///
+/// Mask dimensions follow the transfer's mask layout (see
+/// `inferTransferOpMaskType`): one per source dimension read by the permutation
+/// map, in increasing dimension order, broadcasts dropped. Each size is
+/// `dim - index`. Returns a null type for a pure broadcast: nothing to mask.
----------------
FedericoBruzzone wrote:

[nit] Should this also spell out what happens for a _pure-broadcast_ map (all dims map to constants, no `AffineDimExpr`)?

https://github.com/llvm/llvm-project/pull/226490