[Mlir-commits] [mlir] [mlir][LLVMIR] Skip or and shl folding for mismatched constant types (PR #226026)

[Mehdi Amini]

joker-eph wrote:

I'm not convinced that fixing the folders is the right path: I suspect every folder everywhere would be vulnerable to this issue. A quick check shows that `llvm.zext` crashes the same way, for example. This would be a game of whack-a-mole. 

That points to something more systemic that the framework should handle. The "prior work" seems misguided to me from this point of view. 

I would think that the ultimate fix would be to make sure that every constant in MLIR always folds to an attribute of the same type as the SSA value.
 

https://github.com/llvm/llvm-project/pull/226026