[Mlir-commits] [mlir] [mlir][Quant] Stop using Operation::getAttrs (NFC) (PR #226413)

Mehdi Amini llvmlistbot at llvm.org
Fri Sep 25 02:33:54 PDT 2026


https://github.com/joker-eph created https://github.com/llvm/llvm-project/pull/226413

Pass raw attributes separately from property storage when recreating an operation.

Part of #155475 

Assisted-by: Codex

>From 68bc4e9a34ea584119a05460f611e8a101d16d57 Mon Sep 17 00:00:00 2001
From: Mehdi Amini <joker.eph at gmail.com>
Date: Fri, 25 Sep 2026 02:19:17 -0700
Subject: [PATCH] [mlir][Quant] Stop using Operation::getAttrs

Pass raw attributes separately from property storage when recreating
an operation.

Assisted-by: Codex
---
 mlir/lib/Dialect/Quant/Transforms/NormalizeQuantTypes.cpp | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/mlir/lib/Dialect/Quant/Transforms/NormalizeQuantTypes.cpp b/mlir/lib/Dialect/Quant/Transforms/NormalizeQuantTypes.cpp
index 966d7589d42c3..f08ad268f0647 100644
--- a/mlir/lib/Dialect/Quant/Transforms/NormalizeQuantTypes.cpp
+++ b/mlir/lib/Dialect/Quant/Transforms/NormalizeQuantTypes.cpp
@@ -123,9 +123,10 @@ class ConvertGenericOpwithSubChannelType : public ConversionPattern {
     if (failed(typeConverter->convertTypes(op->getResultTypes(), resultTypes)))
       return failure();
 
-    auto *newOp = Operation::create(
-        op->getLoc(), op->getName(), resultTypes, operands, op->getAttrs(),
-        op->getPropertiesStorage(), op->getSuccessors(), op->getNumRegions());
+    auto *newOp = Operation::create(op->getLoc(), op->getName(), resultTypes,
+                                    operands, op->getRawDictionaryAttrs(),
+                                    op->getPropertiesStorage(),
+                                    op->getSuccessors(), op->getNumRegions());
     for (auto regions : llvm::zip(op->getRegions(), newOp->getRegions())) {
       Region &before = std::get<0>(regions);
       Region &parent = std::get<1>(regions);



More information about the Mlir-commits mailing list