[Mlir-commits] [mlir] [mlir][arith] Support equal-width float conversions (PR #225346)

[Jack Frankland]

FranklandJack wrote:

> LGTM. Initially I was uncertain whether same-type conversions would be handled correctly, but I see there's a check elsewhere `if (operand.getType() == toType)`. For future-proofing you could consider adding same-type fp cases to ensure result == input and that the block remains empty.

We can do, but I feel like at that point we should probably start adding test coverage for the entire surface of this helper which is going to be a lot more extensive.

https://github.com/llvm/llvm-project/pull/225346