[Mlir-commits] [mlir] [mlir][LLVMIR] Skip or and shl folding for mismatched constant types (PR #226026)

[Mehdi Amini]

joker-eph wrote:

> In general, if feels more like a bug of the constant operation rather than a folder bug if the attribute type doesn't match the op type?


I agree. I don't think we should guard every folder everywhere: that's a lot of redundant checks where we likely should address the root cause instead. 

I would consider this a problem with the constants, and it doesn't seem reasonable to me to make every folder defend against this. 

https://github.com/llvm/llvm-project/pull/226026