[Mlir-commits] [mlir] [mlir][linalg] Document and diagnose pack/unpack memref limits (PR #225773)

[llvmlistbot at llvm.org]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp -- mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp mlir/lib/Dialect/Linalg/TransformOps/LinalgTransformOps.cpp mlir/lib/Dialect/Linalg/Transforms/BlockPackMatmul.cpp mlir/lib/Dialect/Linalg/Transforms/DataLayoutPropagation.cpp mlir/lib/Dialect/Linalg/Transforms/PackAndUnpackPatterns.cpp mlir/lib/Dialect/Linalg/Transforms/TilingInterfaceImpl.cpp mlir/lib/Dialect/Linalg/Transforms/Transforms.cpp mlir/lib/Dialect/Linalg/Transforms/Vectorization.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp b/mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp
index 51b5f4a30..d13ad8ef1 100644
--- a/mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp
+++ b/mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp
@@ -6305,7 +6305,8 @@ struct FoldTensorCastPackOp : public OpRewritePattern<PackOp> {
   LogicalResult matchAndRewrite(PackOp op,
                                 PatternRewriter &rewriter) const override {
     // Pack/unpack transformations operate at tensor level. The memref form is
-    // only for inline bufferization and scalar lowering, see #225650 for details.
+    // only for inline bufferization and scalar lowering, see #225650 for
+    // details.
     if (!op.hasPureTensorSemantics())
       return failure();
 
@@ -6790,7 +6791,8 @@ struct FoldTensorCastUnPackOp : public OpRewritePattern<UnPackOp> {
   LogicalResult matchAndRewrite(UnPackOp op,
                                 PatternRewriter &rewriter) const override {
     // Pack/unpack transformations operate at tensor level. The memref form is
-    // only for inline bufferization and scalar lowering, see #225650 for details.
+    // only for inline bufferization and scalar lowering, see #225650 for
+    // details.
     if (!op.hasPureTensorSemantics())
       return failure();
 
diff --git a/mlir/lib/Dialect/Linalg/Transforms/DataLayoutPropagation.cpp b/mlir/lib/Dialect/Linalg/Transforms/DataLayoutPropagation.cpp
index 48531e700..6dbbb8541 100644
--- a/mlir/lib/Dialect/Linalg/Transforms/DataLayoutPropagation.cpp
+++ b/mlir/lib/Dialect/Linalg/Transforms/DataLayoutPropagation.cpp
@@ -573,7 +573,8 @@ public:
   LogicalResult matchAndRewrite(linalg::PackOp packOp,
                                 PatternRewriter &rewriter) const override {
     // Pack/unpack transformations operate at tensor level. The memref form is
-    // only for inline bufferization and scalar lowering, see #225650 for details.
+    // only for inline bufferization and scalar lowering, see #225650 for
+    // details.
     if (!packOp.hasPureTensorSemantics())
       return failure();
 
@@ -601,7 +602,8 @@ public:
   LogicalResult matchAndRewrite(linalg::PackOp packOp,
                                 PatternRewriter &rewriter) const override {
     // Pack/unpack transformations operate at tensor level. The memref form is
-    // only for inline bufferization and scalar lowering, see #225650 for details.
+    // only for inline bufferization and scalar lowering, see #225650 for
+    // details.
     if (!packOp.hasPureTensorSemantics())
       return failure();
 
@@ -973,7 +975,8 @@ public:
   LogicalResult matchAndRewrite(linalg::PackOp packOp,
                                 PatternRewriter &rewriter) const override {
     // Pack/unpack transformations operate at tensor level. The memref form is
-    // only for inline bufferization and scalar lowering, see #225650 for details.
+    // only for inline bufferization and scalar lowering, see #225650 for
+    // details.
     if (!packOp.hasPureTensorSemantics())
       return failure();
 
@@ -1107,7 +1110,8 @@ public:
   LogicalResult matchAndRewrite(linalg::UnPackOp unPackOp,
                                 PatternRewriter &rewriter) const override {
     // Pack/unpack transformations operate at tensor level. The memref form is
-    // only for inline bufferization and scalar lowering, see #225650 for details.
+    // only for inline bufferization and scalar lowering, see #225650 for
+    // details.
     if (!unPackOp.hasPureTensorSemantics())
       return failure();
 
@@ -1311,7 +1315,8 @@ struct PushDownUnPackThroughPadOp : public OpRewritePattern<tensor::PadOp> {
       return failure();
 
     // Pack/unpack transformations operate at tensor level. The memref form is
-    // only for inline bufferization and scalar lowering, see #225650 for details.
+    // only for inline bufferization and scalar lowering, see #225650 for
+    // details.
     if (!unpackOp.hasPureTensorSemantics())
       return failure();
 
diff --git a/mlir/lib/Dialect/Linalg/Transforms/PackAndUnpackPatterns.cpp b/mlir/lib/Dialect/Linalg/Transforms/PackAndUnpackPatterns.cpp
index 9389eac96..7269197cf 100644
--- a/mlir/lib/Dialect/Linalg/Transforms/PackAndUnpackPatterns.cpp
+++ b/mlir/lib/Dialect/Linalg/Transforms/PackAndUnpackPatterns.cpp
@@ -155,7 +155,8 @@ struct SimplifyPackToExpandShape : public OpRewritePattern<PackOp> {
     if (packOp.getPaddingValue())
       return rewriter.notifyMatchFailure(packOp, "expects no padding value");
     // Pack/unpack transformations operate at tensor level. The memref form is
-    // only for inline bufferization and scalar lowering, see #225650 for details.
+    // only for inline bufferization and scalar lowering, see #225650 for
+    // details.
     if (!packOp.hasPureTensorSemantics())
       return failure();
 
@@ -221,7 +222,8 @@ struct SimplifyUnPackToCollapseShape : public OpRewritePattern<UnPackOp> {
   LogicalResult matchAndRewrite(UnPackOp unpackOp,
                                 PatternRewriter &rewriter) const override {
     // Pack/unpack transformations operate at tensor level. The memref form is
-    // only for inline bufferization and scalar lowering, see #225650 for details.
+    // only for inline bufferization and scalar lowering, see #225650 for
+    // details.
     if (!unpackOp.hasPureTensorSemantics())
       return failure();
 
@@ -326,7 +328,8 @@ public:
       return failure();
 
     // Pack/unpack transformations operate at tensor level. The memref form is
-    // only for inline bufferization and scalar lowering, see #225650 for details.
+    // only for inline bufferization and scalar lowering, see #225650 for
+    // details.
     if (!unpackOp.hasPureTensorSemantics())
       return failure();
 
@@ -393,7 +396,8 @@ public:
       return failure();
 
     // Pack/unpack transformations operate at tensor level. The memref form is
-    // only for inline bufferization and scalar lowering, see #225650 for details.
+    // only for inline bufferization and scalar lowering, see #225650 for
+    // details.
     if (!packOp.hasPureTensorSemantics())
       return failure();
 
@@ -457,7 +461,8 @@ public:
   LogicalResult matchAndRewrite(PackOp packOp,
                                 PatternRewriter &rewriter) const override {
     // Pack/unpack transformations operate at tensor level. The memref form is
-    // only for inline bufferization and scalar lowering, see #225650 for details.
+    // only for inline bufferization and scalar lowering, see #225650 for
+    // details.
     if (!packOp.hasPureTensorSemantics())
       return failure();
 
@@ -523,7 +528,8 @@ public:
       return failure();
 
     // Pack/unpack transformations operate at tensor level. The memref form is
-    // only for inline bufferization and scalar lowering, see #225650 for details.
+    // only for inline bufferization and scalar lowering, see #225650 for
+    // details.
     if (!unPackOp.hasPureTensorSemantics())
       return failure();
 
@@ -576,7 +582,8 @@ public:
   LogicalResult matchAndRewrite(UnPackOp unPackOp,
                                 PatternRewriter &rewriter) const override {
     // Pack/unpack transformations operate at tensor level. The memref form is
-    // only for inline bufferization and scalar lowering, see #225650 for details.
+    // only for inline bufferization and scalar lowering, see #225650 for
+    // details.
     if (!unPackOp.hasPureTensorSemantics())
       return failure();
 
@@ -645,7 +652,8 @@ struct FoldEmptyTensorWithPackOp : public OpRewritePattern<PackOp> {
   LogicalResult matchAndRewrite(PackOp packOp,
                                 PatternRewriter &rewriter) const override {
     // Pack/unpack transformations operate at tensor level. The memref form is
-    // only for inline bufferization and scalar lowering, see #225650 for details.
+    // only for inline bufferization and scalar lowering, see #225650 for
+    // details.
     if (!packOp.hasPureTensorSemantics())
       return failure();
 
@@ -674,7 +682,8 @@ struct FoldEmptyTensorWithUnPackOp : public OpRewritePattern<UnPackOp> {
   LogicalResult matchAndRewrite(UnPackOp unPackOp,
                                 PatternRewriter &rewriter) const override {
     // Pack/unpack transformations operate at tensor level. The memref form is
-    // only for inline bufferization and scalar lowering, see #225650 for details.
+    // only for inline bufferization and scalar lowering, see #225650 for
+    // details.
     if (!unPackOp.hasPureTensorSemantics())
       return failure();
 
diff --git a/mlir/lib/Dialect/Linalg/Transforms/TilingInterfaceImpl.cpp b/mlir/lib/Dialect/Linalg/Transforms/TilingInterfaceImpl.cpp
index 3a6d5d922..f4688ba7f 100644
--- a/mlir/lib/Dialect/Linalg/Transforms/TilingInterfaceImpl.cpp
+++ b/mlir/lib/Dialect/Linalg/Transforms/TilingInterfaceImpl.cpp
@@ -1131,7 +1131,8 @@ struct PackOpTiling
                          ArrayRef<OpFoldResult> sizes) const {
     auto packOp = cast<PackOp>(op);
     // Pack/unpack transformations operate at tensor level. The memref form is
-    // only for inline bufferization and scalar lowering, see #225650 for details.
+    // only for inline bufferization and scalar lowering, see #225650 for
+    // details.
     if (!packOp.hasPureTensorSemantics())
       return failure();
 
@@ -1507,7 +1508,8 @@ struct PackOpTiling
 
     auto packOp = cast<PackOp>(op);
     // Pack/unpack transformations operate at tensor level. The memref form is
-    // only for inline bufferization and scalar lowering, see #225650 for details.
+    // only for inline bufferization and scalar lowering, see #225650 for
+    // details.
     if (!packOp.hasPureTensorSemantics())
       return failure();
 
@@ -1726,7 +1728,8 @@ struct UnPackOpTiling
       ArrayRef<InnerTileAlignment> innerTileAlignments) const {
     auto unpackOp = cast<UnPackOp>(op);
     // Pack/unpack transformations operate at tensor level. The memref form is
-    // only for inline bufferization and scalar lowering, see #225650 for details.
+    // only for inline bufferization and scalar lowering, see #225650 for
+    // details.
     if (!unpackOp.hasPureTensorSemantics())
       return failure();
 
@@ -1980,7 +1983,8 @@ struct UnPackOpTiling
     }
     auto unPackOp = cast<UnPackOp>(op);
     // Pack/unpack transformations operate at tensor level. The memref form is
-    // only for inline bufferization and scalar lowering, see #225650 for details.
+    // only for inline bufferization and scalar lowering, see #225650 for
+    // details.
     if (!unPackOp.hasPureTensorSemantics())
       return failure();
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/225773