[Mlir-commits] [mlir] [mlir][vector] Support fixed-size masks in `eliminateVectorMasks` (PR #221595)

[Andrzej Warzyński]

================
@@ -54,9 +57,25 @@ LogicalResult resolveAllTrueCreateMaskOp(IRRewriter &rewriter,
   for (auto [i, dimSize] : unknownDims) {
     // Compute the lower bound for the unknown dimension (i.e. the smallest
     // value it could be).
+    if (!vscaleRange) {
+      // A constant bound cannot prove a scalable dim, whose runtime size is
+      // `vscale` times the size in the type. Checked first to skip the query.
+      if (maskTypeDimScalableFlags[i])
+        return failure();
----------------
banach-space wrote:

Thanks for pointing this out, I didn't notice!

>  Open to revert if you would rather not have the churn.

That would be my preference, but it's totally optional. I appreciated that I've already created extra work for you with no real benefits.

https://github.com/llvm/llvm-project/pull/221595