[Mlir-commits] [mlir] [mlir][Vector] Reject scalable outer dim in multi_reduction unrolling (PR #224174)

[Federico Bruzzone]

https://github.com/FedericoBruzzone commented:

Thank you for the fix @jay87406 :D

I left some comments inline.
However, I think I can write my thoughts here.
The bail leaves the op as `vector.multi_reduction` for inputs that `FlattenMultiReduction` accepts:
https://github.com/llvm/llvm-project/blob/cff5c6387deafa346d73dc89b193ef7ccbd4b60a/mlir/lib/Dialect/Vector/Transforms/LowerVectorMultiReduction.cpp#L183-L186

I’d wait for @banach-space POV on this, but maybe we should be able to support a scalable dim for `vector.multi_reduction` here. If so, I’d at least add a TODO.
Does that make sense to you?

https://github.com/llvm/llvm-project/pull/224174