[Mlir-commits] [mlir] [mlir][LLVMIR] Fix loop follow-up metadata import and export (PR #223376)

Tobias Gysi llvmlistbot at llvm.org
Fri Sep 18 01:19:04 PDT 2026


================
@@ -16,10 +18,16 @@ using namespace mlir::LLVM::detail;
 namespace {
 /// Helper class that keeps the state of one metadata to attribute conversion.
 struct LoopMetadataConversion {
-  LoopMetadataConversion(const llvm::MDNode *node, Location loc,
-                         LoopAnnotationImporter &loopAnnotationImporter)
+  enum class InputKind { LoopID, Followup };
+
+  LoopMetadataConversion(
+      const llvm::MDNode *node, Location loc,
+      LoopAnnotationImporter &loopAnnotationImporter,
+      llvm::SmallPtrSetImpl<const llvm::MDNode *> &activeNodes,
+      InputKind inputKind = InputKind::LoopID)
----------------
gysit wrote:

```suggestion
      InputKind inputKind)
```
nit: I would drop the default value given this is used in two places or so. 

https://github.com/llvm/llvm-project/pull/223376


More information about the Mlir-commits mailing list