[Mlir-commits] [mlir] [mlir][linalg] Hoist masked vector transfer pairs (PR #221481)

[Hugo Pompougnac]

================
@@ -330,8 +370,10 @@ void mlir::linalg::hoistRedundantVectorTransfers(Operation *root,
       // Check 3.
       // TODO: may want to memoize this information for performance but it
       // likely gets invalidated often.
+      // Compare the hoisted units (the `vector.mask` ops when masked) since the
+      // inner transfers live in sibling mask regions and never dominate.
----------------
qaco wrote:

Right, the intent is to compare the candidate read against the candidate write. Reworded to name `readOrMaskedRead`/`writeOrMaskedWrite` directly and explain that when masked these are the wrapping `vector.mask` ops.

https://github.com/llvm/llvm-project/pull/221481