[Mlir-commits] [mlir] [mlir][SCF] Avoid crash in parallel loop unrolling test pass (PR #222644)

[purnima shrivastava]

================
@@ -0,0 +1,11 @@
+// RUN: split-file %s %t
+// RUN: mlir-opt %t/missing-factors.mlir -test-parallel-loop-unrolling -verify-diagnostics
+// RUN: mlir-opt %t/zero-factor.mlir -test-parallel-loop-unrolling='unroll-factors=1,0' -verify-diagnostics
----------------
purnima-nlp wrote:

I checked the existing SCF `*-invalid.mlir` tests. They use `-split-input-file` when all sections are run with the same pass options.

Here the two cases need different invocations: one without `unroll-factors`, and one with `unroll-factors=1,0`, so a single `mlir-opt %s -split-input-file ...` command cannot apply the appropriate options per section.

Would you prefer keeping `split-file` for these two cases, or splitting them into two separate invalid test files? I’m happy to follow whichever style you prefer.


https://github.com/llvm/llvm-project/pull/222644