[Mlir-commits] [mlir] [mlir][SCF] Avoid crash in parallel loop unrolling test pass (PR #222644)

[Federico Bruzzone]

FedericoBruzzone wrote:

> @FedericoBruzzone By the earlier comment, I meant whether emitError + signalPassFailure() should be used for both the missing unroll-factor case and the zero-factor case, or only for the zero-factor validation. Sorry, my wording wasn't clear.

What you've currently implemented, SGTM :D

> Regarding not: I added it because signalPassFailure() makes mlir-opt return a failure status, so the test is expected to fail while FileCheck verifies the diagnostic. Without not, lit should treat that non-zero exit status as a test failure. I'll double-check that behavior as well.

Oh, thank you! It makes perfect sense. 

https://github.com/llvm/llvm-project/pull/222644