[Mlir-commits] [mlir] [mlir][DLTI] Handle builtin types when combining data layouts (PR #222874)

[Mehdi Amini]

joker-eph wrote:

> I’d also ask you to be mindful of your tone and wording. Feedback can be given without sounding dismissive, and I think we can be more welcoming to people who are joining the project and trying to contribute.

Please accept all of my apologies if you feel like anything was dismissive here. That was not my intent. 
You seem to take my answer as if the use of AI was a negative thing. I don't say it that way. I'm doing extensive use of AI myself. Actually 100% of the PRs I am submitted are written by my agent. 
So there really was no criticism intended here. However, the project policy is to disclose the use of AI in the PR description, and these days, most people are unaware and/or just forget to tag it in their description, so that was just a reminder about it. 

More importantly, the PR description really looked AI-generated to me. 

> Regarding the PR description, I’m happy to remove actual repetition, but I prefer to keep useful information about scope, regression coverage, and validation. I use the PR as part of the engineering record of what was exercised and what the change is intended to cover.

I will insist that you rethink the way the PR description is useful. It should focus on the context and the "why" instead of the "what".  
You may want to have a look at our official published guideline: https://mlir.llvm.org/getting_started/Contributing/#commit-messages and the post it links to.

Thanks again for the contribution. 

https://github.com/llvm/llvm-project/pull/222874