[Mlir-commits] [mlir] [mlir][vector] Fix mask neutral value for masked fmaximum/fminimum reductions (PR #222275)

[Andrzej Warzyński]

banach-space wrote:

> @banach-space any more comments/issues?

LGTM, thank you!

Could you please leave a bit more time between a "ping" and landing a patch next time? Another common practice is to let reviewers know that you intend to land a patch within, say, the next 24 hours.

It can be a little discouraging to spend time reviewing a patch only to see it land without an explicit LGTM, or without confirmation from other reviewers that the comments have been addressed.

I appreciate that response times can be slow, but the upstream review backlog is very long and we have relatively few people regularly reviewing patches.

https://github.com/llvm/llvm-project/pull/222275