[Mlir-commits] [mlir] [mlir][vector] Reject a 0-d operand in the outerproduct parser (PR #219917)

[Alessandro Potenza]

alepot55 wrote:

The title probably oversells it: nothing becomes invalid that isn't already. `verify()` rejects a rank-0 operand with this exact message (https://github.com/llvm/llvm-project/blob/29fda2c4ecca4520526656893c36d738fbc78348/mlir/lib/Dialect/Vector/IR/VectorOps.cpp#L4417-L4423), but the parser reads `getScalableDims()[0]` and `getDimSize(0)` first to build the result type, so mlir-opt asserts on `vector<f32>` before the verifier can say anything. All this does is run the same check ahead of that read. Inferring size 1 there would build a result type for an op the verifier then rejects anyway, unless the rank check goes too, which is the 0-d discussion you're pointing at. Does that change the picture, or would you rather it wait for that discussion?

https://github.com/llvm/llvm-project/pull/219917