[Mlir-commits] [mlir] [mlir][linalg] Add `insert_slice` vectorization tests for leading/trailing dropped dims (PR #221966)

[Federico Bruzzone]

FedericoBruzzone wrote:

> After double-checking I realised that you are right, sorry for the noise!

No worries at all :D

> Is this really correct? Most pre-existing tests do not require that. Indeed, there's logic to handle cases when the padding value cannot be recovered: https://github.com/llvm/llvm-project/blob/f41d0ccf125b14e1206e5bfedaae516ffe58b887/mlir/lib/Dialect/Linalg/Transforms/Vectorization.cpp?plain=1#L2975-L2979
> Am I missing something?

Mmm... that's very interesting. I'll have to check it out as soon as I'm back at my machine. Thanks for pointing it out. I'll let you know. Most likely I missed something :'D

https://github.com/llvm/llvm-project/pull/221966