[Mlir-commits] [mlir] [mlir][linalg] Hoist transfer pairs through disjoint subview slices (PR #220244)

[Andrzej Warzyński]

================
@@ -351,5 +352,133 @@ bool hasNegativeStaticStride(MemRefType memRefTy) {
   });
 }
 
+namespace {
+// TODO: This footprint modelling and its logic overlap with
+// `SubsetOpInterface`, which is unfortunately tensor-only today; if it gains
+// memref support, look into unifying with it to improve code reuse.
+//
+/// Footprint of a memref value relative to a `root` memref reached through a
+/// chain of rank-preserving, unit-stride `memref.subview` ops: per `root`
----------------
banach-space wrote:

[nit] "unit-stride" only makes sense for the trailing dim. For non trailing dim, we need "identity" layout rather than unit strides (the former implies unit stride for the trailing dim). This will become clearer once you consider examples with rank > 2.

https://github.com/llvm/llvm-project/pull/220244