[Mlir-commits] [mlir] [mlir][linalg] Support non-trailing dropped dims when vectorizing rank-reducing `InsertSliceOp` (PR #219192)

[Andrzej Warzyński]

https://github.com/banach-space commented:

Hey @FedericoBruzzone , thank you for this addition!

All in all LGTM, but I don't see any other tests for vectorizing `tensor.insert_slice` when the source and destination ranks differ. It would good to test those scenarios as well (i.e. leading + trailing unit dims being skipped). WOuld you be able to extend this? Thank you!

[ultra nit] Unify the naming scheme (`%empty` -> `%init`, `%init` -> `%source_slice`).

https://github.com/llvm/llvm-project/pull/219192