[Mlir-commits] [clang] [llvm] [mlir] [ADT] Give DenseMapPair its own members instead of a std::pair base. NFC (PR #221853)

[Kazu Hirata]

================
@@ -241,8 +241,8 @@ void BitcodeReaderMetadataList::tryToResolveCycles() {
     return;
 
   // Give up on finding a full definition for any forward decls that remain.
-  for (const auto &Ref : OldTypeRefs.FwdDecls)
-    OldTypeRefs.Final.insert(Ref);
+  for (const auto &[UUID, CT] : OldTypeRefs.FwdDecls)
+    OldTypeRefs.Final.try_emplace(UUID, CT);
----------------
kazutakahirata wrote:

I think I suggested structured bindings here earlier, but I should have suggested:
```suggestion
  OldTypeRefs.Final.insert_range(OldTypeRefs.FwdDecls);
```


https://github.com/llvm/llvm-project/pull/221853