[Mlir-commits] [mlir] [mlir][LLVM] Remove dead constant verifier return (NFC) (PR #221833)

[Mehdi Amini]

https://github.com/joker-eph created https://github.com/llvm/llvm-project/pull/221833

Every arm of the constant attribute-kind chain returns directly, leaving the final success return unreachable. Remove the dead statement.

Found by Coverity.

Assisted-by: Codex

>From 9fa208e41f169b594ef0f13b30a256719d951c89 Mon Sep 17 00:00:00 2001
From: Mehdi Amini <joker.eph at gmail.com>
Date: Mon, 7 Sep 2026 06:58:53 -0700
Subject: [PATCH] [mlir][LLVM] Remove dead constant verifier return

Every arm of the constant attribute-kind chain returns directly, leaving the
final success return unreachable. Remove the dead statement.

Found by Coverity.

Assisted-by: Codex
---
 mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp | 2 --
 1 file changed, 2 deletions(-)

diff --git a/mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp b/mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp
index cd6425f4a63fa..c257dc75c5aea 100644
--- a/mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp
+++ b/mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp
@@ -3767,8 +3767,6 @@ LogicalResult LLVM::ConstantOp::verify() {
     return emitOpError()
            << "only supports integer, float, string or elements attributes";
   }
-
-  return success();
 }
 
 bool LLVM::ConstantOp::isBuildableWith(Attribute value, Type type) {