[Mlir-commits] [mlir] [mlir][gpu] Preserve argument attributes during kernel outlining (PR #221465)

[purnima shrivastava]

purnima-nlp wrote:

> > Thank you so much, @FedericoBruzzone !! This makes the direction much clearer for me. I really appreciate you taking the time to explain it and confirm the approach. I’ll wait for @fabianmcg ’s input on the exact representation, then I’ll start working on the prerequisite `gpu.launch` patch. :)
> 
> I'm currently leaning towards the following: add `Variadic<AnyType>:$calling_convention` and `OptionalAttr<DictArrayAttr>:$arg_attrs` arguments. Modify the description of the op to specify what they do, as well as the parser/printer of the op. Also add a region verifier, checking that each operand in the calling convention appears in the region at least once (see RegionUtils.h and `getUsedValuesDefinedAbove`). As part of the design, the calling convention operands will appear first in the kernel and in the order they appear in the op. Add utility functions to remove and add calling convention args.

Ohh that's great ! Thanks for your direction.

https://github.com/llvm/llvm-project/pull/221465