[Mlir-commits] [mlir] [mlir] Fix non-termination when a block becomes unreachable during rewriting (PR #221152)

[Mehdi Amini]

joker-eph wrote:

> Such IR is invalid outside of a graph region, so the canonicalization should not apply.

No, it's not. 
It is entirely legal in unreachable blocks.
Specifically, for the propose of allowing such transformations !
(I thought you were me at this discussion last year already?)

https://github.com/llvm/llvm-project/pull/221152