[Mlir-commits] [mlir] [mlir][scf] Fix the scf.while result reconstructed by upliftWhileToForLoop (PR #219617)
llvmlistbot at llvm.org
llvmlistbot at llvm.org
Sat Sep 5 10:53:21 PDT 2026
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp -- mlir/lib/Dialect/SCF/Transforms/UpliftWhileToFor.cpp --diff_from_common_commit
``````````
:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/mlir/lib/Dialect/SCF/Transforms/UpliftWhileToFor.cpp b/mlir/lib/Dialect/SCF/Transforms/UpliftWhileToFor.cpp
index 75dcd12f0..1db9a43a5 100644
--- a/mlir/lib/Dialect/SCF/Transforms/UpliftWhileToFor.cpp
+++ b/mlir/lib/Dialect/SCF/Transforms/UpliftWhileToFor.cpp
@@ -249,8 +249,8 @@ FailureOr<scf::ForOp> mlir::scf::upliftWhileToForLoop(RewriterBase &rewriter,
// Assumes a strictly positive `step`. The matcher does not check this, so a
// non-positive step breaks the ceil-div and also builds an `scf.for` that
// violates its own contract; pre-existing gap, not repairable here.
- Value zero = arith::ConstantOp::create(
- rewriter, loc, rewriter.getZeroAttr(step.getType()));
+ Value zero = arith::ConstantOp::create(rewriter, loc,
+ rewriter.getZeroAttr(step.getType()));
Value stepDec = arith::SubIOp::create(rewriter, loc, step, one);
Value len = arith::SubIOp::create(rewriter, loc, ub, lb);
``````````
</details>
https://github.com/llvm/llvm-project/pull/219617
More information about the Mlir-commits
mailing list