[Mlir-commits] [mlir] [mlir][affine] Fix replaceAllMemRefUsesWith failing on memref.load/store (PR #217833)

[Federico Bruzzone]

================
@@ -1356,8 +1356,10 @@ LogicalResult mlir::affine::replaceAllMemRefUsesWith(
 
     // Check if the memref was used in a non-dereferencing context. It is fine
     // for the memref to be used in a non-dereferencing way outside of the
-    // region where this replacement is happening.
-    if (!isa<AffineMapAccessInterface>(*user)) {
+    // region where this replacement is happening. Note: memref.load/store are
+    // dereferencing ops even though they don't implement
+    // AffineMapAccessInterface.
----------------
FedericoBruzzone wrote:

```suggestion
    // region where this replacement is happening. 
    // NOTE: memref.load/store are dereferencing ops even 
    // though they don't implement AffineMapAccessInterface.
```

https://github.com/llvm/llvm-project/pull/217833