[Mlir-commits] [llvm] [mlir] [mlir] Reland SymbolUserTypeInterface with verification proportional to participating IR (PR #212354)

[Jared Hoberock]

jaredhoberock wrote:

Thanks, added your repro to the benchmark suite and measured the five design points on it:
  
  | build | wall | instructions / pass | peak RSS |
  |---|---|---|---|
  | before the interface (post-revert main) | 1.17 s | 165 M | 79 MB |
  | interface as landed (#198435) | 3.80 s | 6.0 G | 79 MB |
  | this branch, walker only (no cache) | 1.20 s | 184 M | 79 MB |
  | this branch, cache per verifier scope | 1.18 s | 182 M | 79 MB |
  | this branch, cache on the context | 1.18 s | 181 M | 79 MB |

So the current PR brings your program back to within ~1% of the pre-interface floor on wall time (~10% on instructions per pass), and the hoisted walker alone accounts for essentially all of the recovery.

https://github.com/llvm/llvm-project/pull/212354