[Mlir-commits] [mlir] de261e3 - [MLIR][IRDL] Move generated dialect strings into storage (NFC) (#221072)

[llvmlistbot at llvm.org]

Author: Mehdi Amini
Date: 2026-09-03T22:49:35Z
New Revision: de261e3c44944b21755aa53d593a99a5fabaa3c0

URL: https://github.com/llvm/llvm-project/commit/de261e3c44944b21755aa53d593a99a5fabaa3c0
DIFF: https://github.com/llvm/llvm-project/commit/de261e3c44944b21755aa53d593a99a5fabaa3c0.diff

LOG: [MLIR][IRDL] Move generated dialect strings into storage (NFC) (#221072)

Move locally assembled C++ names and namespace fragments into the
dialect string table. Their temporary strings are not used after the
table entry is built, so copying their allocations is unnecessary.

Found by Coverity.

Assisted-by: Codex

Added: 
    

Modified: 
    mlir/lib/Target/IRDLToCpp/IRDLToCpp.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/lib/Target/IRDLToCpp/IRDLToCpp.cpp b/mlir/lib/Target/IRDLToCpp/IRDLToCpp.cpp
index 40d7d3cd91708..2bbd9de0ec51b 100644
--- a/mlir/lib/Target/IRDLToCpp/IRDLToCpp.cpp
+++ b/mlir/lib/Target/IRDLToCpp/IRDLToCpp.cpp
@@ -723,12 +723,12 @@ irdl::translateIRDLDialectToCpp(llvm::ArrayRef<irdl::DialectOp> dialects,
 
     DialectStrings dialectStrings;
     dialectStrings.dialectName = dialectName;
-    dialectStrings.dialectBaseTypeName = dialectBaseTypeName;
-    dialectStrings.dialectCppName = cppName;
-    dialectStrings.dialectCppShortName = cppShortName;
-    dialectStrings.namespaceOpen = namespaceOpen;
-    dialectStrings.namespaceClose = namespaceClose;
-    dialectStrings.namespacePath = namespacePath;
+    dialectStrings.dialectBaseTypeName = std::move(dialectBaseTypeName);
+    dialectStrings.dialectCppName = std::move(cppName);
+    dialectStrings.dialectCppShortName = std::move(cppShortName);
+    dialectStrings.namespaceOpen = std::move(namespaceOpen);
+    dialectStrings.namespaceClose = std::move(namespaceClose);
+    dialectStrings.namespacePath = std::move(namespacePath);
 
     dialectStringTable[dialect] = std::move(dialectStrings);
   }