[Mlir-commits] [mlir] [mlir][tblgen] Avoid copies when iterating symbols (NFC) (PR #220910)

[LLVM Continuous Integration]

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `amdgpu-clang-flang` running on `AMD-bb-w-05` while building `mlir` at step 3 "annotate".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/234/builds/3833

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 3 (annotate) failure: 'python ../llvm.src/offload/ci/openmp-offload-amdgpu-clang-flang.py ...' (failure)
...
PASS: libomptarget :: x86_64-unknown-linux-gnu :: mapping/use_device_ptr/target_data_use_device_ptr_class_member_ref_fallback_preserve.cpp (1183 of 1412)
PASS: libomptarget :: x86_64-unknown-linux-gnu :: mapping/use_device_ptr/target_data_use_device_ptr_class_member_ref_with_map.cpp (1184 of 1412)
PASS: libomptarget :: x86_64-unknown-linux-gnu :: mapping/target_data_array_extension_at_exit.c (1185 of 1412)
PASS: libomptarget :: x86_64-unknown-linux-gnu :: mapping/target_derefence_array_pointrs.cpp (1186 of 1412)
PASS: libomptarget :: x86_64-unknown-linux-gnu :: mapping/use_device_ptr/target_data_use_device_ptr_class_member_with_map.cpp (1187 of 1412)
PASS: libomptarget :: x86_64-unknown-linux-gnu :: mapping/use_device_ptr/target_data_use_device_ptr_existing.cpp (1188 of 1412)
PASS: libomptarget :: x86_64-unknown-linux-gnu :: offloading/disable_default_device.c (1189 of 1412)
UNSUPPORTED: libomptarget :: x86_64-unknown-linux-gnu :: offloading/distribute_for_no_loop_num_threads.c (1190 of 1412)
PASS: libomptarget :: x86_64-unknown-linux-gnu :: mapping/implicit_device_ptr.c (1191 of 1412)
PASS: libomptarget :: x86_64-unknown-linux-gnu :: mapping/is_accessible.cpp (1192 of 1412)
FAIL: libomptarget :: amdgpu-amd-amdhsa :: tools/omp-kernel-replay/record-replay-empty-memory.cpp (1193 of 1412)
******************** TEST 'libomptarget :: amdgpu-amd-amdhsa :: tools/omp-kernel-replay/record-replay-empty-memory.cpp' FAILED ********************
Exit Code: 125

Command Output (stdout):
--
# RUN: at line 2
/home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/./bin/clang++ -fopenmp    -I /home/botworker/bbot/amdgpu-clang-flang/llvm.src/offload/test -I /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/runtimes/runtimes-bins/openmp/runtime/src -I /home/botworker/bbot/amdgpu-clang-flang/llvm.src/offload/test/../languages/include -I /home/botworker/bbot/amdgpu-clang-flang/llvm.src/offload/test/../languages/include/cuda -I /home/botworker/bbot/amdgpu-clang-flang/llvm.src/offload/test/../languages/include/hip -I /home/botworker/bbot/amdgpu-clang-flang/llvm.src/offload/test/../languages/kernel/include -L /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/./lib/x86_64-unknown-linux-gnu -L /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/./lib/x86_64-unknown-linux-gnu -L /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/./lib -L /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/runtimes/runtimes-bins/openmp/runtime/src  -Wl,-rpath,/home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/./lib/x86_64-unknown-linux-gnu -Wl,-rpath,/home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/runtimes/runtimes-bins/openmp/runtime/src -Wl,-rpath,/home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/./lib/x86_64-unknown-linux-gnu -Wl,-rpath,/home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/./lib -Xoffload-linker -L/home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/./lib/amdgpu-amd-amdhsa -Xoffload-linker -L/home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/./lib/clang/24/lib/amdgpu-amd-amdhsa  -fopenmp-targets=amdgpu-amd-amdhsa /home/botworker/bbot/amdgpu-clang-flang/llvm.src/offload/test/tools/omp-kernel-replay/record-replay-empty-memory.cpp -o /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/runtimes/runtimes-bins/offload/test/amdgpu-amd-amdhsa/tools/omp-kernel-replay/Output/record-replay-empty-memory.cpp.tmp -Xoffload-linker -lompdevice
# executed command: /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/./bin/clang++ -fopenmp -I /home/botworker/bbot/amdgpu-clang-flang/llvm.src/offload/test -I /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/runtimes/runtimes-bins/openmp/runtime/src -I /home/botworker/bbot/amdgpu-clang-flang/llvm.src/offload/test/../languages/include -I /home/botworker/bbot/amdgpu-clang-flang/llvm.src/offload/test/../languages/include/cuda -I /home/botworker/bbot/amdgpu-clang-flang/llvm.src/offload/test/../languages/include/hip -I /home/botworker/bbot/amdgpu-clang-flang/llvm.src/offload/test/../languages/kernel/include -L /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/./lib/x86_64-unknown-linux-gnu -L /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/./lib/x86_64-unknown-linux-gnu -L /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/./lib -L /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/runtimes/runtimes-bins/openmp/runtime/src -Wl,-rpath,/home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/./lib/x86_64-unknown-linux-gnu -Wl,-rpath,/home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/runtimes/runtimes-bins/openmp/runtime/src -Wl,-rpath,/home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/./lib/x86_64-unknown-linux-gnu -Wl,-rpath,/home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/./lib -Xoffload-linker -L/home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/./lib/amdgpu-amd-amdhsa -Xoffload-linker -L/home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/./lib/clang/24/lib/amdgpu-amd-amdhsa -fopenmp-targets=amdgpu-amd-amdhsa /home/botworker/bbot/amdgpu-clang-flang/llvm.src/offload/test/tools/omp-kernel-replay/record-replay-empty-memory.cpp -o /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/runtimes/runtimes-bins/offload/test/amdgpu-amd-amdhsa/tools/omp-kernel-replay/Output/record-replay-empty-memory.cpp.tmp -Xoffload-linker -lompdevice
# note: command had no output on stdout or stderr
# RUN: at line 3
rm -rf /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/runtimes/runtimes-bins/offload/test/amdgpu-amd-amdhsa/tools/omp-kernel-replay/Output/record-replay-empty-memory.cpp.tmp.testdir
# executed command: rm -rf /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/runtimes/runtimes-bins/offload/test/amdgpu-amd-amdhsa/tools/omp-kernel-replay/Output/record-replay-empty-memory.cpp.tmp.testdir
# note: command had no output on stdout or stderr
# RUN: at line 4
mkdir -p /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/runtimes/runtimes-bins/offload/test/amdgpu-amd-amdhsa/tools/omp-kernel-replay/Output/record-replay-empty-memory.cpp.tmp.testdir
# executed command: mkdir -p /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/runtimes/runtimes-bins/offload/test/amdgpu-amd-amdhsa/tools/omp-kernel-replay/Output/record-replay-empty-memory.cpp.tmp.testdir
# note: command had no output on stdout or stderr
# RUN: at line 5
env LIBOMPTARGET_RECORD=1 LIBOMPTARGET_RECORD_MEMSIZE=536870912 LIBOMPTARGET_RECORD_DIR=/home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/runtimes/runtimes-bins/offload/test/amdgpu-amd-amdhsa/tools/omp-kernel-replay/Output/record-replay-empty-memory.cpp.tmp.testdir /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/runtimes/runtimes-bins/offload/test/amdgpu-amd-amdhsa/tools/omp-kernel-replay/Output/record-replay-empty-memory.cpp.tmp 2>&1 | /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/./bin/FileCheck /home/botworker/bbot/amdgpu-clang-flang/llvm.src/offload/test/tools/omp-kernel-replay/record-replay-empty-memory.cpp
# executed command: env LIBOMPTARGET_RECORD=1 LIBOMPTARGET_RECORD_MEMSIZE=536870912 LIBOMPTARGET_RECORD_DIR=/home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/runtimes/runtimes-bins/offload/test/amdgpu-amd-amdhsa/tools/omp-kernel-replay/Output/record-replay-empty-memory.cpp.tmp.testdir /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/runtimes/runtimes-bins/offload/test/amdgpu-amd-amdhsa/tools/omp-kernel-replay/Output/record-replay-empty-memory.cpp.tmp
# note: command had no output on stdout or stderr
# executed command: /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/./bin/FileCheck /home/botworker/bbot/amdgpu-clang-flang/llvm.src/offload/test/tools/omp-kernel-replay/record-replay-empty-memory.cpp
# note: command had no output on stdout or stderr
# RUN: at line 6
ls -t /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/runtimes/runtimes-bins/offload/test/amdgpu-amd-amdhsa/tools/omp-kernel-replay/Output/record-replay-empty-memory.cpp.tmp.testdir/*.json | sed -n '1p' | grep . | xargs -I {} /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/./bin/llvm-omp-kernel-replay --verify {}
# executed command: ls -t '/home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/runtimes/runtimes-bins/offload/test/amdgpu-amd-amdhsa/tools/omp-kernel-replay/Output/record-replay-empty-memory.cpp.tmp.testdir/*.json'
# note: command had no output on stdout or stderr
# executed command: sed -n 1p
# note: command had no output on stdout or stderr
# executed command: grep .
# note: command had no output on stdout or stderr
# executed command: xargs -I '{}' /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/./bin/llvm-omp-kernel-replay --verify '{}'
# .---command stdout------------
# | [llvm-omp-kernel-replay] Replay time (1): 878648 ns
# | [llvm-omp-kernel-replay] Replay done, device memory verified
# `-----------------------------
# .---command stderr------------
# | xargs: /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/./bin/llvm-omp-kernel-replay: terminated by signal 11
Step 9 (Add check check-offload) failure: Add check check-offload (failure)
...
PASS: libomptarget :: x86_64-unknown-linux-gnu :: mapping/use_device_ptr/target_data_use_device_ptr_class_member_ref_fallback_preserve.cpp (1183 of 1412)
PASS: libomptarget :: x86_64-unknown-linux-gnu :: mapping/use_device_ptr/target_data_use_device_ptr_class_member_ref_with_map.cpp (1184 of 1412)
PASS: libomptarget :: x86_64-unknown-linux-gnu :: mapping/target_data_array_extension_at_exit.c (1185 of 1412)
PASS: libomptarget :: x86_64-unknown-linux-gnu :: mapping/target_derefence_array_pointrs.cpp (1186 of 1412)
PASS: libomptarget :: x86_64-unknown-linux-gnu :: mapping/use_device_ptr/target_data_use_device_ptr_class_member_with_map.cpp (1187 of 1412)
PASS: libomptarget :: x86_64-unknown-linux-gnu :: mapping/use_device_ptr/target_data_use_device_ptr_existing.cpp (1188 of 1412)
PASS: libomptarget :: x86_64-unknown-linux-gnu :: offloading/disable_default_device.c (1189 of 1412)
UNSUPPORTED: libomptarget :: x86_64-unknown-linux-gnu :: offloading/distribute_for_no_loop_num_threads.c (1190 of 1412)
PASS: libomptarget :: x86_64-unknown-linux-gnu :: mapping/implicit_device_ptr.c (1191 of 1412)
PASS: libomptarget :: x86_64-unknown-linux-gnu :: mapping/is_accessible.cpp (1192 of 1412)
FAIL: libomptarget :: amdgpu-amd-amdhsa :: tools/omp-kernel-replay/record-replay-empty-memory.cpp (1193 of 1412)
******************** TEST 'libomptarget :: amdgpu-amd-amdhsa :: tools/omp-kernel-replay/record-replay-empty-memory.cpp' FAILED ********************
Exit Code: 125

Command Output (stdout):
--
# RUN: at line 2
/home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/./bin/clang++ -fopenmp    -I /home/botworker/bbot/amdgpu-clang-flang/llvm.src/offload/test -I /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/runtimes/runtimes-bins/openmp/runtime/src -I /home/botworker/bbot/amdgpu-clang-flang/llvm.src/offload/test/../languages/include -I /home/botworker/bbot/amdgpu-clang-flang/llvm.src/offload/test/../languages/include/cuda -I /home/botworker/bbot/amdgpu-clang-flang/llvm.src/offload/test/../languages/include/hip -I /home/botworker/bbot/amdgpu-clang-flang/llvm.src/offload/test/../languages/kernel/include -L /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/./lib/x86_64-unknown-linux-gnu -L /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/./lib/x86_64-unknown-linux-gnu -L /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/./lib -L /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/runtimes/runtimes-bins/openmp/runtime/src  -Wl,-rpath,/home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/./lib/x86_64-unknown-linux-gnu -Wl,-rpath,/home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/runtimes/runtimes-bins/openmp/runtime/src -Wl,-rpath,/home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/./lib/x86_64-unknown-linux-gnu -Wl,-rpath,/home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/./lib -Xoffload-linker -L/home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/./lib/amdgpu-amd-amdhsa -Xoffload-linker -L/home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/./lib/clang/24/lib/amdgpu-amd-amdhsa  -fopenmp-targets=amdgpu-amd-amdhsa /home/botworker/bbot/amdgpu-clang-flang/llvm.src/offload/test/tools/omp-kernel-replay/record-replay-empty-memory.cpp -o /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/runtimes/runtimes-bins/offload/test/amdgpu-amd-amdhsa/tools/omp-kernel-replay/Output/record-replay-empty-memory.cpp.tmp -Xoffload-linker -lompdevice
# executed command: /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/./bin/clang++ -fopenmp -I /home/botworker/bbot/amdgpu-clang-flang/llvm.src/offload/test -I /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/runtimes/runtimes-bins/openmp/runtime/src -I /home/botworker/bbot/amdgpu-clang-flang/llvm.src/offload/test/../languages/include -I /home/botworker/bbot/amdgpu-clang-flang/llvm.src/offload/test/../languages/include/cuda -I /home/botworker/bbot/amdgpu-clang-flang/llvm.src/offload/test/../languages/include/hip -I /home/botworker/bbot/amdgpu-clang-flang/llvm.src/offload/test/../languages/kernel/include -L /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/./lib/x86_64-unknown-linux-gnu -L /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/./lib/x86_64-unknown-linux-gnu -L /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/./lib -L /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/runtimes/runtimes-bins/openmp/runtime/src -Wl,-rpath,/home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/./lib/x86_64-unknown-linux-gnu -Wl,-rpath,/home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/runtimes/runtimes-bins/openmp/runtime/src -Wl,-rpath,/home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/./lib/x86_64-unknown-linux-gnu -Wl,-rpath,/home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/./lib -Xoffload-linker -L/home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/./lib/amdgpu-amd-amdhsa -Xoffload-linker -L/home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/./lib/clang/24/lib/amdgpu-amd-amdhsa -fopenmp-targets=amdgpu-amd-amdhsa /home/botworker/bbot/amdgpu-clang-flang/llvm.src/offload/test/tools/omp-kernel-replay/record-replay-empty-memory.cpp -o /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/runtimes/runtimes-bins/offload/test/amdgpu-amd-amdhsa/tools/omp-kernel-replay/Output/record-replay-empty-memory.cpp.tmp -Xoffload-linker -lompdevice
# note: command had no output on stdout or stderr
# RUN: at line 3
rm -rf /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/runtimes/runtimes-bins/offload/test/amdgpu-amd-amdhsa/tools/omp-kernel-replay/Output/record-replay-empty-memory.cpp.tmp.testdir
# executed command: rm -rf /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/runtimes/runtimes-bins/offload/test/amdgpu-amd-amdhsa/tools/omp-kernel-replay/Output/record-replay-empty-memory.cpp.tmp.testdir
# note: command had no output on stdout or stderr
# RUN: at line 4
mkdir -p /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/runtimes/runtimes-bins/offload/test/amdgpu-amd-amdhsa/tools/omp-kernel-replay/Output/record-replay-empty-memory.cpp.tmp.testdir
# executed command: mkdir -p /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/runtimes/runtimes-bins/offload/test/amdgpu-amd-amdhsa/tools/omp-kernel-replay/Output/record-replay-empty-memory.cpp.tmp.testdir
# note: command had no output on stdout or stderr
# RUN: at line 5
env LIBOMPTARGET_RECORD=1 LIBOMPTARGET_RECORD_MEMSIZE=536870912 LIBOMPTARGET_RECORD_DIR=/home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/runtimes/runtimes-bins/offload/test/amdgpu-amd-amdhsa/tools/omp-kernel-replay/Output/record-replay-empty-memory.cpp.tmp.testdir /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/runtimes/runtimes-bins/offload/test/amdgpu-amd-amdhsa/tools/omp-kernel-replay/Output/record-replay-empty-memory.cpp.tmp 2>&1 | /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/./bin/FileCheck /home/botworker/bbot/amdgpu-clang-flang/llvm.src/offload/test/tools/omp-kernel-replay/record-replay-empty-memory.cpp
# executed command: env LIBOMPTARGET_RECORD=1 LIBOMPTARGET_RECORD_MEMSIZE=536870912 LIBOMPTARGET_RECORD_DIR=/home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/runtimes/runtimes-bins/offload/test/amdgpu-amd-amdhsa/tools/omp-kernel-replay/Output/record-replay-empty-memory.cpp.tmp.testdir /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/runtimes/runtimes-bins/offload/test/amdgpu-amd-amdhsa/tools/omp-kernel-replay/Output/record-replay-empty-memory.cpp.tmp
# note: command had no output on stdout or stderr
# executed command: /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/./bin/FileCheck /home/botworker/bbot/amdgpu-clang-flang/llvm.src/offload/test/tools/omp-kernel-replay/record-replay-empty-memory.cpp
# note: command had no output on stdout or stderr
# RUN: at line 6
ls -t /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/runtimes/runtimes-bins/offload/test/amdgpu-amd-amdhsa/tools/omp-kernel-replay/Output/record-replay-empty-memory.cpp.tmp.testdir/*.json | sed -n '1p' | grep . | xargs -I {} /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/./bin/llvm-omp-kernel-replay --verify {}
# executed command: ls -t '/home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/runtimes/runtimes-bins/offload/test/amdgpu-amd-amdhsa/tools/omp-kernel-replay/Output/record-replay-empty-memory.cpp.tmp.testdir/*.json'
# note: command had no output on stdout or stderr
# executed command: sed -n 1p
# note: command had no output on stdout or stderr
# executed command: grep .
# note: command had no output on stdout or stderr
# executed command: xargs -I '{}' /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/./bin/llvm-omp-kernel-replay --verify '{}'
# .---command stdout------------
# | [llvm-omp-kernel-replay] Replay time (1): 878648 ns
# | [llvm-omp-kernel-replay] Replay done, device memory verified
# `-----------------------------
# .---command stderr------------
# | xargs: /home/botworker/bbot/amdgpu-clang-flang/build/llvm.build/./bin/llvm-omp-kernel-replay: terminated by signal 11

```

</details>

https://github.com/llvm/llvm-project/pull/220910