[Mlir-commits] [clang] [mlir] [CIR] Honor the Direct coercion offset in x86_64 callconv lowering (PR #220724)

[Erich Keane]

================
@@ -383,9 +421,10 @@ mlir::Value emitCoercion(mlir::OpBuilder &builder, mlir::Location loc,
 /// (e.g. call-site coercion where we don't replaceAllUsesExcept).
 mlir::Value emitCoercion(mlir::OpBuilder &builder, mlir::Location loc,
                          mlir::Type dstTy, mlir::Value src,
-                         mlir::Block *slotBlock, const mlir::DataLayout &dl) {
+                         mlir::Block *slotBlock, const mlir::DataLayout &dl,
+                         unsigned offset = 0) {
----------------
erichkeane wrote:

Could we remove the offset=0 (the default arg) from everywhere in this patch?  Is it really too big of a task to change all uses to pass the offset knowingly?

https://github.com/llvm/llvm-project/pull/220724