joker-eph wrote: To me one litmus test for NFC is "is there test changes" and "should there be test changes": it is suspicious when there is a non-NFC path without tests, and vice-versa (exceptions likely exist) https://github.com/llvm/llvm-project/pull/217295