[Mlir-commits] [mlir] [mlir][OpenACC] Avoid per-recipe module walks in ACCImplicitDeclare (PR #220478)

[llvmlistbot at llvm.org]

github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Windows-->
# :window: Windows x64 Test Results

* 4117 tests passed
* 450 tests skipped
* 1 test failed

## Failed Tests
(click on a test name to see its output)

### MLIR
<details>
<summary>MLIR.Dialect/OpenACC/acc-implicit-declare.mlir</summary>

```
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 1
c:\_work\llvm-project\llvm-project\build\bin\mlir-opt.exe C:\_work\llvm-project\llvm-project\mlir\test\Dialect\OpenACC\acc-implicit-declare.mlir --pass-pipeline="builtin.module(acc-implicit-declare)" -split-input-file 2>&1 | c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe C:\_work\llvm-project\llvm-project\mlir\test\Dialect\OpenACC\acc-implicit-declare.mlir
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\mlir-opt.exe' 'C:\_work\llvm-project\llvm-project\mlir\test\Dialect\OpenACC\acc-implicit-declare.mlir' '--pass-pipeline=builtin.module(acc-implicit-declare)' -split-input-file
# note: command had no output on stdout or stderr
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe' 'C:\_work\llvm-project\llvm-project\mlir\test\Dialect\OpenACC\acc-implicit-declare.mlir'
# .---command stderr------------
# | C:\_work\llvm-project\llvm-project\mlir\test\Dialect\OpenACC\acc-implicit-declare.mlir:130:11: error: CHECK: expected string not found in input
# | // CHECK: memref.global @global_for_private {{.*}} {acc.declare = #acc.declare<dataClause = acc_copyin>}
# |           ^
# | <stdin>:57:136: note: scanning from here
# |  memref.global constant @gscalarconst_routine : memref<f32> = dense<1.000000e+00> {acc.declare = #acc.declare<dataClause = acc_copyin>}
# |                                                                                                                                        ^
# | <stdin>:123:48: note: possible intended match here
# |  memref.global constant @global_serial_const : memref<f32> = dense<1.000000e+00> {acc.declare = #acc.declare<dataClause = acc_copyin>}
# |                                                ^
# | 
# | Input file: <stdin>
# | Check file: C:\_work\llvm-project\llvm-project\mlir\test\Dialect\OpenACC\acc-implicit-declare.mlir
# | 
# | -dump-input=help explains the following input dump.
# | 
# | Input was:
# | <<<<<<
# |              .
# |              .
# |              .
# |             52:  } 
# |             53: } 
# |             54:  
# |             55: // ----- 
# |             56: module { 
# |             57:  memref.global constant @gscalarconst_routine : memref<f32> = dense<1.000000e+00> {acc.declare = #acc.declare<dataClause = acc_copyin>} 
# | check:130'0                                                                                                                                           {   search range start (exclusive)
# | check:130'1                                                                                                                                               error: no match found in search range
# |             58:  acc.routine @acc_routine_0 func(@test_constant_in_accroutine) 
# |             59:  func.func @test_constant_in_accroutine() attributes {acc.routine_info = #acc.routine_info<[@acc_routine_0]>} { 
# |             60:  %0 = memref.get_global @gscalarconst_routine : memref<f32> 
# |             61:  %1 = memref.load %0[] : memref<f32> 
# |             62:  return 
# |              .
# |              .
# |              .
# |            118:  
# |            119: // ----- 
# |            120: module { 
# |            121:  memref.global @global_parallel : memref<f32> = dense<0.000000e+00> 
# |            122:  memref.global @global_kernels : memref<f32> = dense<0.000000e+00> 
# |            123:  memref.global constant @global_serial_const : memref<f32> = dense<1.000000e+00> {acc.declare = #acc.declare<dataClause = acc_copyin>} 
# | check:130'2                                                    ?                                                                                         possible intended match
# |            124:  func.func @test_multiple_constructs() { 
# | check:130'3                                         }      search range end (exclusive)
# |            125:  %0 = memref.get_global @global_parallel : memref<f32> 
# |            126:  acc.parallel { 
# |            127:  %2 = memref.load %0[] : memref<f32> 
# |            128:  acc.yield 
# |            129:  } 
# |              .
# |              .
# |              .
# | >>>>>>
# `-----------------------------
# error: command failed with exit status: 1

--

```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/220478