[Mlir-commits] [mlir] [mlir][tosa] Add F32 to F16 type narrowing pass (PR #218900)

[Luke Hutton]

================
@@ -714,29 +755,39 @@ LogicalResult runTosaNarrowing(Operation *op, bool aggressiveRewrite,
     populateReturnOpTypeConversionPattern(patterns, typeConverter);
   }
   if (aggressiveRewrite) {
-    patterns.add<ConvertGenericOp<Kind>>(typeConverter, context,
-                                         allowLossyConversion);
+    patterns.add<ConvertGenericOp<Kind>>(
+        typeConverter, context, allowLossyConversion, convertAccumulatorType);
   } else {
     if constexpr (Kind == TosaNarrowKind::Int64ToInt32) {
       patterns.add<ConvertArgMaxOpWithBoundsChecking>(typeConverter, context);
       patterns.add<ConvertClampOpWithBoundsChecking<Kind>>(typeConverter,
                                                            context);
     }
-    patterns.add<ConvertTypedOp<tosa::ConstOp, Kind>>(typeConverter, context);
-    patterns.add<ConvertTypedOp<tosa::ConcatOp, Kind>>(typeConverter, context);
-    patterns.add<ConvertTypedOp<tosa::PadOp, Kind>>(typeConverter, context);
-    patterns.add<ConvertTypedOp<tosa::ReshapeOp, Kind>>(typeConverter, context);
-    patterns.add<ConvertTypedOp<tosa::ReverseOp, Kind>>(typeConverter, context);
-    patterns.add<ConvertTypedOp<tosa::SliceOp, Kind>>(typeConverter, context);
-    patterns.add<ConvertTypedOp<tosa::TileOp, Kind>>(typeConverter, context);
-    patterns.add<ConvertTypedOp<tosa::TransposeOp, Kind>>(typeConverter,
-                                                          context);
-    patterns.add<ConvertTypedOp<tosa::IdentityOp, Kind>>(typeConverter,
-                                                         context);
+    patterns.add<ConvertTypedOp<tosa::ConstOp, Kind>>(typeConverter, context,
----------------
lhutton1 wrote:

Wondering if we need to pass `convertAccumulatorType` to `ConvertTypedOp` right now if none of the ops used have an accumulator type?

https://github.com/llvm/llvm-project/pull/218900